Remove unused "setup" functions in interpreter #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only actually call any setup function on SymbolClosure's
|
I probably won't have enough time to do this review for a few weeks, but then I'd like to take a better look at how and where setup-like functions are used, mainly because before removing them I want to make sure we can't make better simplifications elsewhere using them. |
|
I'd like to make further simplifications in this area, but probably best not to keep this PR until that happens. |
mahrud
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on a few commits that I'd originally proposed in #3419.
We remove some of the
setupfamily of functions incommon.d(which are used for associating a symbol with its function) that weren't being used anywhere:Wordargument.setup(SymbolClosure, unop, unop)(for unary operators that are both prefix and postfix, of which we have none)setupfun(string, unop)We also remove
setup(SymbolClosure, unop)since it was identical tosetupop.